Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: a per_page param to OGM API URI #150

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Add: a per_page param to OGM API URI #150

merged 1 commit into from
Apr 2, 2023

Conversation

ewlarson
Copy link
Contributor

HT @karenmajewicz

This PR allows GeoCombine to harvest all repositories by passing a per_page param along with the API call.

Before

ewlarson@beanburrito .internal_test_app % bundle exec rake geocombine:clone --trace
** Invoke geocombine:clone (first_time)
** Execute geocombine:clone
Cloned https://github.com/OpenGeoMetadata/shared-repository.git
Cloned https://github.com/OpenGeoMetadata/edu.stanford.purl.git
Cloned https://github.com/OpenGeoMetadata/edu.princeton.arks.git
Cloned https://github.com/OpenGeoMetadata/edu.virginia.git
Cloned https://github.com/OpenGeoMetadata/edu.nyu.git
Cloned https://github.com/OpenGeoMetadata/edu.harvard.git
Cloned https://github.com/OpenGeoMetadata/edu.umn.git
Cloned https://github.com/OpenGeoMetadata/edu.tufts.git
Cloned https://github.com/OpenGeoMetadata/edu.columbia.git
Cloned https://github.com/OpenGeoMetadata/edu.lclark.git
Cloned https://github.com/OpenGeoMetadata/gov.data.git
Cloned https://github.com/OpenGeoMetadata/geobtaa.git
Cloned https://github.com/OpenGeoMetadata/edu.uarizona.git
Cloned https://github.com/OpenGeoMetadata/edu.berkeley.git
Cloned https://github.com/OpenGeoMetadata/edu.cornell.git
Cloned https://github.com/OpenGeoMetadata/edu.vt.git
Cloned https://github.com/OpenGeoMetadata/edu.upenn.git
Cloned https://github.com/OpenGeoMetadata/edu.mit.git
Cloned https://github.com/OpenGeoMetadata/ca.frdr.geodisy.git
Cloned https://github.com/OpenGeoMetadata/edu.wisc.git
Cloned 20 repositories

After

ewlarson@beanburrito GeoCombine % bundle exec rake geocombine:clone
Cloned https://github.com/OpenGeoMetadata/shared-repository.git
Cloned https://github.com/OpenGeoMetadata/edu.stanford.purl.git
Cloned https://github.com/OpenGeoMetadata/edu.princeton.arks.git
Cloned https://github.com/OpenGeoMetadata/edu.virginia.git
Cloned https://github.com/OpenGeoMetadata/edu.nyu.git
Cloned https://github.com/OpenGeoMetadata/edu.harvard.git
Cloned https://github.com/OpenGeoMetadata/edu.umn.git
Cloned https://github.com/OpenGeoMetadata/edu.tufts.git
Cloned https://github.com/OpenGeoMetadata/edu.columbia.git
Cloned https://github.com/OpenGeoMetadata/edu.lclark.git
Cloned https://github.com/OpenGeoMetadata/gov.data.git
Cloned https://github.com/OpenGeoMetadata/geobtaa.git
Cloned https://github.com/OpenGeoMetadata/edu.uarizona.git
Cloned https://github.com/OpenGeoMetadata/edu.berkeley.git
Cloned https://github.com/OpenGeoMetadata/edu.cornell.git
Cloned https://github.com/OpenGeoMetadata/edu.vt.git
Cloned https://github.com/OpenGeoMetadata/edu.upenn.git
Cloned https://github.com/OpenGeoMetadata/edu.mit.git
Cloned https://github.com/OpenGeoMetadata/ca.frdr.geodisy.git
Cloned https://github.com/OpenGeoMetadata/edu.wisc.git
Cloned https://github.com/OpenGeoMetadata/edu.uchicago.git
Cloned https://github.com/OpenGeoMetadata/edu.indiana.git
Cloned https://github.com/OpenGeoMetadata/edu.illinois.git
Cloned https://github.com/OpenGeoMetadata/edu.umich.git
Cloned https://github.com/OpenGeoMetadata/edu.psu.git
Cloned https://github.com/OpenGeoMetadata/edu.msu.git
Cloned https://github.com/OpenGeoMetadata/edu.uiowa.git
Cloned https://github.com/OpenGeoMetadata/edu.umd.git
Cloned https://github.com/OpenGeoMetadata/edu.gmu.git
Cloned https://github.com/OpenGeoMetadata/edu.purdue.git
Cloned https://github.com/OpenGeoMetadata/edu.unl.git
Cloned https://github.com/OpenGeoMetadata/edu.osu.git
Cloned https://github.com/OpenGeoMetadata/edu.rutgers.git
Cloned 33 repositories

Fixes #149

@ewlarson @karenmajewicz
Add: a per_page param to OGM API URI
92fcae0 
Fixes #149

Co-Authored-By: Karen Majewicz <[email protected]>
thatbudakguy
thatbudakguy approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@thatbudakguy thatbudakguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for figuring this out! the list seemed a little short to me too...

@thatbudakguy thatbudakguy merged commit 6b2fd2b into main Apr 2, 2023
@thatbudakguy thatbudakguy deleted the 149-clone-all-repos branch April 2, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatbudakguy thatbudakguy thatbudakguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Repositories API call is missing several Big Ten members?
2 participants
@ewlarson @thatbudakguy